Files

T

vadimwit 096e431157 ledger: seed sprint-jamguide-piano; L-10 done (Critic PASS); promote D-10/C-10; log iteration

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-06-15 19:05:45 +01:00

34 KiB

Raw Blame History

Ensemble Ledger — Live Task Board

The shared queue all agents read and write. Lifecycle and rules: PROTOCOL.md. Roster + cadence weights: ROSTER.md.

Status: backlog → ready → claimed → in-review → done / returned Lock: a task's files column is its lock — no two claimed/in-review tasks may overlap files.

Active sprint: `sprint-jamguide-piano` (branch: `sprint-jamguide-piano`)

Goal: extend the shipped Roadmap Jam Guide to piano (guitar→piano→bass roadmap). When the Piano instrument tab is selected, each Roadmap station shows a generated piano voicing on a mini-keyboard — voicings computed from the progression's degrees+qualities (GOAL G4: generate piano voicings from interval recipes; no authored data needed for the MVP). Branch cut off sprint-jam-guide HEAD. Weights: Luthier 3, Muse 2, Critic gate.

id	title	domain	status	depends-on	files (lock)	definition of done
M-02	Cut `sprint-jamguide-piano` branch off `sprint-jam-guide`; seed sprint	maestro	done	—	(branch)	branch cut, ledger seeded
L-10	`src/lib/piano.js` — pure piano voicing resolver: `pianoVoicing({rootPc, quality}, opts?)` → shell (1-3-7), rootless A/B (3-5-7-9 / 7-9-3-5), root-position; picks the inversion minimizing movement from a previous voicing (voice-leading); returns absolute key positions + pcs + a label	engineering	done	M-02	`src/lib/piano.js`	pure fns; correct tones for all 14 CHORD_TYPES; voice-leading-minimal vs a prev voicing; build + smoke green; output shape documented for D-10/L-11
D-10	`src/components/MiniPiano.jsx` — SVG mini-keyboard (~2 octaves) highlighting a voicing's notes (root in accent), thumb/full sizes, design tokens, AA contrast	design	ready	L-10	`src/components/MiniPiano.jsx`	renders any `pianoVoicing` output in any key; compiles standalone; legible at thumb size
L-11	Wire piano into `JamGuide.jsx`: Piano tab active; per station render `MiniPiano` from `pianoVoicing`; keep the guitar path intact	engineering	backlog	L-10, D-10	`src/components/JamGuide.jsx`	piano tab shows per-station keyboards synced to the loop; guitar unchanged; build green
C-10	Extend `scripts/smoke.mjs`: assert `pianoVoicing` returns a valid voicing for every KB quality (no crash, notes in range, contains the chord's defining tones); also assert no duplicate absolute note across styles (the sus2 forced-rootless nit from L-10 gate)	quality	ready	L-10	`scripts/smoke.mjs`	smoke covers the piano resolver; exits non-zero on regression

Piano authored packs (signature comps overriding computed voicings) are deferred to a later sprint — computed voicings suffice for the piano MVP.

Shipped sprint: `sprint-jam-guide` (branch: `sprint-jam-guide`, PR #2 — complete)

Emphasis this sprint: ship the Jam Guide MVP (put the 8 guitar style packs on screen, synced to live detection) + reframe the repo as a learning platform. Weights this sprint: Luthier 3, Muse 3 (design-heavy), Professor 2, Herald 2, Critic gate.

Design-first gate (user directive 2026-06-14): Muse explored three distinct concepts; user chose "Roadmap" (improv-first highway) on 2026-06-15. Implementation tasks below are re-planned to build Roadmap. Concept doc: docs/design/jam-guide-concept-c.md. Stage/Playbook (-a/-b) kept as reference for future modes.

Roadmap build shape: a horizontal timeline panel — stations (= loop chords) carry guide-tone lanes (3rd/7th), a solo-scale label, and voice-leading rails (7→3) between stations; a playhead + beat grid track loop position; the chosen voicing is a secondary thumbnail per station; tap a station → guide tones on the fretboard. Needs derived theory (guideTones, voiceLeadingPairs, default soloScale) — Luthier owns those.

id	title	domain	status	depends-on	files (lock)	definition of done
M-01	Cut `sprint-jam-guide` branch; seed sprint	maestro	done	—	(branch)	branch cut, ledger header set
D-00a	Viz concept A — "Stage"	design	done	—	`docs/design/jam-guide-concept-a.md`	delivered; reference for future collapsed/glance mode
D-00b	Viz concept B — "Playbook"	design	done	—	`docs/design/jam-guide-concept-b.md`	delivered; reference for future study mode
D-00c	Viz concept C — "Roadmap"	design	done	—	`docs/design/jam-guide-concept-c.md`	delivered; CHOSEN
D-SEL	User selects a concept	maestro	done	D-00a, D-00b, D-00c	`docs/agents/LEDGER.md`	Roadmap chosen 2026-06-15; tasks re-planned below
L-01	Shared matcher: extract/author `findLoopPosition` (which chord index the loop is on) + rotation-invariant degree-relative loop→progression-id matcher into `src/lib/match.js`; refactor `ProgressionBanner.jsx` to use it	engineering	done	M-01	`src/lib/match.js`, `src/components/ProgressionBanner.jsx`	matcher maps detected loop → style progression id (rotation-invariant) AND returns current position index for the playhead; banner still works; build green — VERIFY: `npm run build` green; banner renders identically (findLoopPosition now imported from match.js); matchLoopToProgression rotation-invariant + quality tie-break (smoke: ii–V–I & its rotation → jazz-251-major rot 0/2; minor 251 → jazz-251-minor; chromatic → no match)
L-01b	Derived theory for Roadmap: add `guideTones(chordRoot,quality)` (3rd & 7th pcs), `voiceLeadingPairs(chordA,chordB)` (7→3 / nearest-tone rails), and default `soloScale(quality,mode)` (Mixo/dom7, Dorian/m7, Ionian/maj7…) to `theory.js` — additive exports only	engineering	done	M-01	`src/lib/theory.js`	pure functions, unit-sane (ii–V–I in C → C→B, F→E rails); reuses existing `getChordTones`; build green; no existing export changed
L-02	`JamGuide.jsx` panel shell: mounts last in `App.jsx`, reads `kb/index.js`, instrument+style tabs from registry, collapsed header → ~70vh; receives live loop + position props	engineering	done	L-01	`src/components/JamGuide.jsx`, `src/App.jsx`	panel renders, tabs from KB, matched progression or fallback; build green
D-01	`RoadmapTrack.jsx` — the heart: horizontal stations (loop chords) with guide-tone lanes (3rd/7th dots), solo-scale label, voice-leading rails between stations, playhead + beat grid, lookahead highlight on the next station	design	done	L-01, L-01b	`src/components/RoadmapTrack.jsx`	renders a real ii–V–I & a 12-bar blues from KB; lanes computed from `guideTones`/`voiceLeadingPairs`/`soloScale`; design tokens; AA contrast
D-01b	`ChordDiagram.jsx` — secondary per-station voicing thumbnail (movable `rootStr`+`offsets`, open `frets`+`onlyRoot`), key-aware fret placement, tap-to-enlarge	design	done	L-01	`src/components/ChordDiagram.jsx`	renders any KB guitar shape in any key; chord-tone colour tier; compact thumbnail + enlarged states
D-02	Roadmap assembly & live polish in `JamGuide.jsx`: place `RoadmapTrack` + thumbnails, animate playhead against BPM/onset, narrow-viewport reflow, tap-station → fretboard guide tones	design	done	L-02, D-01, D-01b	`src/components/JamGuide.jsx` (assembly/styling), `tailwind.config.js`	playhead tracks position; reflows on narrow; keyboard-reachable; AA contrast
D-03	Finish the flagship: tap a Roadmap station → highlight that chord's guide tones (3rd/7th) on the main Fretboard. Lift a `jamFocusChord` state into `App.jsx`, `JamGuide` emits the selected station's `{rootPc, quality}` via a callback prop, `Fretboard` highlights those guide tones reusing its existing tier rendering. Returned by Critic → also fix root cause `guideTones` so 4-tone non-seventh chords (add9/maj6/min6) don't badge their 5th/6th as a "7"	engineering	done	D-02	`src/App.jsx`, `src/components/JamGuide.jsx`, `src/components/Fretboard.jsx`, `src/lib/theory.js`	tapping a station lights its 3rd/7th (honest secondary anchor for non-7th chords); build green; smoke green; audio-callback contract intact; RoadmapTrack lane also corrected; keyboard-reachable; clears on deselect
P-01	Gospel guitar KB cell	content	done	—	`src/data/kb/gospel/**`, `src/data/kb/index.js`	5 progressions × 2 plays, validator green (run `/kb-expand`)
P-02	Pop guitar KB cell	content	done	P-01	`src/data/kb/pop/**`, `src/data/kb/index.js`	5 progressions × 2 plays, validator green
H-01	README reframe: lead with the learning-platform vision (detect → guide → learn), screenshot/gif placeholder, link `GOAL.md` + `docs/agents/`	community	done	—	`README.md`	README states the dual vision; links resolve
H-02	`CONTRIBUTING.md` + issue templates: the data-contract path so a musician can PR a style without coding (point at `src/data/kb/SCHEMA.md`)	community	done	H-01	`CONTRIBUTING.md`, `.github/ISSUE_TEMPLATE/**`	a non-coder can follow "add a style"; `/kb-expand` documented as the assisted path
C-01	Smoke-test harness: a `scripts/smoke.mjs` that imports `kb/index.js` + runs the matcher on sample loops, wired alongside `validate-kb.mjs`	quality	done	L-01	`scripts/smoke.mjs`	catches a broken matcher/registry before merge; documented in PROTOCOL gate

Critic (C-) reviews every L-/D-/P-/H- task as it reaches in-review — those reviews are the gate, not separate ledger rows, except where new test infra is itself the deliverable (e.g. C-01).

GATE 2026-06-15 (Critic) · L-01 PASS — build green, validator green (8 styles/40 progs/80 plays). findLoopPosition extracted byte-identical (verified by diff, no semantic change). matchLoopToProgression verified rotation-invariant with quality tie-break: [Dm7,G7,Cmaj7]→jazz-251-major rot 0; rotation [G7,Cmaj7,Dm7]→ rot 2; [Dm7b5,G7,Cm7]→jazz-251-minor (tie-break works); chromatic→clean {matched:false}. rotation index correctly points at the loop slot aligning with KB degrees[0]. match.js holds only matching/position logic + a small local chord-root parser (theory.js exposes no pc helper — acceptable). Note (non-blocking): banner refactor also adds onChordClick click affordances — beyond a pure extract but already wired to setSelectedChord/ChordDetailModal in App.jsx and behaviour-preserving for findLoopPosition. Minor: match.js uses extensionless import … from './theory' (works under Vite; matches existing education.js convention). GATE 2026-06-15 (Critic) · L-01b PASS — build green. theory.js diff is purely additive (zero - lines; no existing export touched). Verified by running the real functions: ii–V–I in C → Dm7→G7 = C→B (−1) and G7→Cmaj7 = F→E (−1) rails (plus intentional 0-semitone common-tone rails). guideTones triad fallback flags hasSeventh:false and uses the 5th. soloScale defaults sane: dom7→mixolydian, min7→dorian, maj7→major(ionian), half_dim→locrian, dom7/minor→phrygian-dominant. Functions are pure and reuse CHORD_TYPES/SCALES. GATE 2026-06-15 (Critic) · L-02 PASS — build green; validator green (8 styles/40 progs/80 plays). 🚨 Audio contract INTACT: git diff HEAD -- src/App.jsx is +10 lines, zero deletions — only the import JamGuide line and the <JamGuide …/> mount (placed last, after the tuner block). handleNote/handleChroma/handleOnset lines do not appear anywhere in the diff; no useCallback dep, ref-sync useEffect, or AudioCapture prop was touched. Black-screen/infinite-restart risk avoided. All 5 props passed (detectedProgression, effectiveKey, chordHistory, bpm, currentChord) exist in App scope. Tabs derive from the KB registry (instrument availability from style.instruments keys, style labels from meta.label); matched-progression vs. dashed-fallback both render. Disabled instrument tabs marked "soon" with disabled + title. GATE 2026-06-15 (Critic) · D-01 PASS — RoadmapTrack renders from props only (pure/presentational). Verified against the real KB: guide-tone honesty confirmed by running guideTones — C-major triad returns hasSeventh:false, secondary anchor = the 5th (pc 7), and the Station labels it "5th" not "7th" (seventhKind gate at line 113). The headline rail picks voiceLeadingPairs(...)[0] = the 7→3: Dm7→G7 ⇒ C→B (−1), G7→Cmaj7 ⇒ F→E (−1). BeatGrid station-start indexing is canonical-order-consistent with the stations array; playhead pct clamps at 0 when position=-1. Tokens used; aria-current, role=progressbar + aria-valuetext, focus rings present. Malformed/empty progression → graceful "no loop to map" card, no crash. GATE 2026-06-15 (Critic) · D-01b PASS — ChordDiagram movable base-fret formula verified independently: E-shape A7 → fret 5 ✓ (rootStr 6, rootPc 9: ((9−4)%12)=5); A-shape C → fret 3 ✓; open-string root → octave barre (12), a sane degradation. Root-tone coloured in accent tier (isRoot → #a855f7), non-root dots light-gray (AA on dark board). Both thumb/full sizes; full adds finger numbers + label. Undefined/unplaceable shape (root > fret 15 or !shape) → graceful "—" placeholder, no crash — covers the empty-thumbnail path. Open vs movable forms both handled. GATE 2026-06-15 (Critic) · P-01 PASS — validator green: ✓ KB valid — 9 style(s), 45 progressions, 90 plays (gospel now included); npm run build green (gospel imported by kb/index.js, 87 modules, built in 5.65s). Schema: 5 progressions × 2 plays = 10 plays, all ids gospel--prefixed, rn/qualities/bars all length-consistent with degrees, qualities all in CHORD_TYPES (min7/dom7/maj7/maj/add9/sus4/dim7). No duplicate id across all 45. Registered in index.js mirroring the other 8 styles (no broken import). Voicings hand-verified (independent pc computation matching the validator's): SHELL_6.maj7 → {0,11,4}=R-7-3 ✓; SUS4_5 → {0,5,7}=R-4-5 ✓; DIM7_5 → {0,6,9,3}=R-♭5-𝄫7-♭3 symmetric ✓; ADD9_6 → {0,2,4,7} full add9 (9th present) ✓; MIN9_5 → {0,2,3,7,10} full min9 ✓ — confirms the validator genuinely exercises these shapes via checkGuitarShape. Theory sound: backdoor ♭VII7=pc10 rises a whole step to I; #iv°7=pc6 passing chord; 6-2-5-1 + plagal IV-I Amen tag; cascading cycle-of-dominants all correctly spelled. Authenticity honest: attributions hedged appropriately ("traditional gospel turnaround", "reharmonized", "Every Praise … vamp feel", "e.g. Tenderly bars 5-7" as a back-door reference) — no claim that a specific recording uses an exact voicing; no music-theory error in any tip (Dorian-over-min7, Mixo-over-dom7, sus-non-resolution advice all correct). Non-blocking nit: a few shape comments list tones in interval order, not low-to-high string order (e.g. MAJ9_6 "R–3–7–9" sounds R-9-3-7) — labeling nicety, all tones present and correctly spelled; not a defect. GATE 2026-06-15 (Critic) · H-01 PASS — every relative link resolves on disk: GOAL.md, CLAUDE.md, src/data/kb/SCHEMA.md, src/data/kb/jazz/ (dir), docs/agents/ + ROSTER/PROTOCOL/LEDGER all exist; CONTRIBUTING.md is correctly referenced as "coming (tracked as task H-02)" and does NOT exist on disk — honest, not a dead live-link. Every command real: electron:dev, dev, electron:build:win|mac|linux all in package.json; scripts/validate-kb.mjs exists. No frontend/ path remains; build output dir stated as release/ matches electron-builder directories.output: "release". git clone URL whattheflat/whattheflat.git matches actual origin. Honesty verified: gospel described as "landing next" (not shipped, still in-review at review time); Piano/bass packs, Progression Builder, detection-powered drills all under In progress, not today; Roadmap Jam Guide listed as working-today (true — D-02 passed, MVP live). Leads with detect → guide → level up; links GOAL.md + docs/agents/. No overstatement found. GATE 2026-06-15 (Critic) · P-02 PASS — gated against the FINAL combined tree (P-02/H-02/C-01 merged). node scripts/validate-kb.mjs → ✓ KB valid — 10 style(s), 50 progressions, 100 plays (pop registered in index.js; the transient "pop not registered" mid-batch failure is resolved — index.js imports popMeta/popProgressions/popGuitar and exports the pop block). Schema: 5 progressions × 2 plays = 10, all ids pop--prefixed, no duplicate across all 50 (verified). Voicings hand-computed (independent pc calc): OPEN_CADD9 → {0,2,4,7} = R-9-3-5, the 9th (pc2) genuinely present (true add9, not plain C) ✓; OPEN_G/OPEN_F → {0,4,7} major ✓; BARRE_MAJ_6 (E-shape) {0,4,7}, BARRE_MIN_5 (Am-shape) {0,3,7}, BARRE_MAJ_5 (A-shape) {0,4,7} ✓ — confirms validator exercises the shapes. Non-duplication judged ACCEPTABLE: pop-axis (0-7-9-5 maj) shares shape with rock-axis/reggae-nwnc and pop-mixo-bVII (0-10-5 mixo) with rock-mixo-vamp, but ids differ, songs differ (No Woman No Cry/Adele/Beatles vs rock), and guitar plays are capo-and-open framed vs rock's barre framing — a real genre reuse with distinct content, not a duplication smell; differentiation rationale documented in the progressions.js header. Honesty CONFIRMED: every sus2/sus4 mention is prose (note/tips/styleIntro) framed as a hammer-on/pull-off fill over a held chord ("the chord stays major, your finger wiggles"); zero sus in the data — all pop-mixo chords are voiced plain maj; tips never claim a voicing the data lacks. Song attributions hedged (Clocks "♭VII colour", Royals "verse", Memories "Pachelbel, set in B"). GATE 2026-06-15 (Critic) · H-02 PASS — every relative link resolves on disk: GOAL.md, README.md, src/data/kb/SCHEMA.md, gospel/{meta,progressions,guitar}.js, index.js, src/lib/theory.js, scripts/validate-kb.mjs, docs/agents/ROSTER.md, and all three issue templates (add-style/bug_report/feature_request) + config.yml — verified via on-disk existence check. Every command real (npm install / electron:dev / dev / build / node scripts/validate-kb.mjs all in package.json). Schema fidelity exact: the quality list maj,min,dom7,maj7,min7,dim,dim7,half_dim,aug,sus4,sus2,maj6,min6,add9 matches CHORD_TYPES keys byte-for-byte; modes list matches the validator's MODES; degrees-0-11, movable(rootStr/offsets) vs open(frets/onlyRoot), and extensions/rootless/omit3 explanations all match SCHEMA.md + validator logic — no invented field, no drift. LICENSE correctly NOT added (CONTRIBUTING honestly states "doesn't have a license file yet … reuse terms aren't settled"). Issue templates present and sane. Non-blocking nit: CONTRIBUTING's illustrative validator-output sample reads 9 style(s)/45/90 (true at authoring time, pre-pop) — it's a "what a passing run looks like" example, not a load-bearing claim; the instructions don't depend on the count. Worth a one-char refresh to 10/50/100 someday, not a return. GATE 2026-06-15 (Critic) · C-01 PASS — node scripts/smoke.mjs → ✓ Smoke test passed — 71/71 checks green (10 styles, 50 progressions), exit 0; reports the FULL final KB (10 styles, derived from the loaded registry, not hardcoded). Imports the REAL kb/index.js + match.js (no mocks); asserts registry integrity (every style meta/progressions[]/instruments.guitar, per-prog degrees/qualities/rn/bars consistency, cross-KB id uniqueness) and matcher correctness (ii–V–I matched:true + structural rebased-degree-shape check, rotation invariance to the SAME derived id with non-zero rotation, axis match guarded with skip-if-absent, chromatic → matched:false/id:null, findLoopPosition in-range/-1/-1-on-empty). Exits non-zero on failure (mirrors validate-kb). Adversarial proof: sabotaged matchLoopToProgression to always return no-match → smoke FAILED 4 checks, exit code 1 (assertions are NOT too weak — a broken matcher cannot pass). match.js restored, no diff. Resolve hook judged SOUND: the inline module.register ESM hook retries ONLY on catch, ONLY for relative+extensionless specifiers (/^\.{1,2}\// && !/\.[mc]?js$/) — verified the regex skips ./theory.js, react, node:url, ./a.mjs and retries only ./theory/../lib/match; it cannot mask a genuine missing module (the .js retry itself surfaces the real ERR_MODULE_NOT_FOUND). Correctly chosen over editing match.js (locked to L-01). No npm script added (validate-kb has none) — package.json untouched (git: only src/data/kb/index.js is modified; smoke.mjs/pop/CONTRIBUTING/templates are new untracked). No hardcoded fragile ids — expected ids derived from the loaded KB; survives KB growth. GATE 2026-06-15 (Critic) · D-03 FAIL (returned) — build green (vite, 90 modules, 10.66s); validator green (✓ KB valid — 10 style(s), 50 progressions, 100 plays, no KB change). 🚨 Audio contract INTACT: git diff -- src/App.jsx is purely additive — exactly (a) one new useState(jamFocusChord/null) placed in the UI-state block (outside all audio-callback/ref logic, with a comment that it is not read by any callback), (b) jamFocusChord={jamFocusChord} on the existing <Fretboard> mount, (c) onFocusChord={setJamFocusChord} on the existing <JamGuide> mount. Grep of the changed lines for handleNote|handleChroma|handleOnset|useCallback|AudioCapture|Ref|useEffect → NO MATCHES. No callback, ref, ref-sync useEffect, or AudioCapture prop touched. Black-screen/infinite-restart risk avoided. Wiring correct: JamGuide emits {rootPc, quality:qualities[i]} (station's actual KB quality) on select, null on deselect; the existing selectedStation→null reset effect (loop/style/instrument change) flows through the new cross-link effect and clears the highlight; an unmount-cleanup effect also clears; all guarded onFocusChord?. so JamGuide stays standalone. Fretboard null path verified unchanged (hasFocus=false ⇒ tag always null ⇒ if(!color&&!tag) collapses to original if(!color); no halo/badge/legend). Emphasis is visually distinct (purple ring DOT_R+3 + degree badge, accent token #a855f7). Triad labeling correct for maj/min/dim/aug/sus4/sus2 (all hasSeventh:false → badge/legend read "5"). DEFECT (blocking): guideTones' secondary-anchor heuristic is hasSeventh = ints.length >= 4, so the 4-tone non-seventh KB qualities add9 [0,2,4,7], maj6/min6 [0,4,7,9] return hasSeventh:true with seventh = ints[last] = the 5th (add9) or 6th (maj6/min6). D-03's focusLabel trusts that boolean and badges those tones "7", legend reads "3 / 7" — a perfect fifth / sixth rendered to the user as a seventh on the flagship Fretboard. Reachable: add9 is in gospel progression qualities (×4), min6 in bossa + rnb qualities — tapping those stations mislabels a non-7th. Verified by running guideTones(0,'add9')→{third:4,seventh:7,hasSeventh:true} (G badged "7"), guideTones(0,'min6')→{third:3,seventh:9,hasSeventh:true} (A badged "7"). The DoD's "the chord's guide tones (3rd/7th)" / "badge reads 5 not 7 for a triad" contract is violated for these KB-present qualities. Fix direction (return to Luthier): make the secondary anchor honest for extended non-7th chords — either tighten guideTones so a chord with no minor/major 7th reports hasSeventh:false and falls back to the 5th (root cause, L-01b owns theory.js), or have focusLabel/the badge derive the actual interval of seventh above root (10/11 ⇒ "7", 9 ⇒ "6", 7 ⇒ "5", 2 ⇒ "9") rather than trusting the boolean. Re-gate after fix. GATE 2026-06-15 (Critic) · D-03 PASS (re-gate) — the returned defect is fixed at the root cause and hardened. npm run build green (vite, 90 modules, built in 3.25s); node scripts/smoke.mjs → ✓ Smoke test passed — 71/71 checks green (10 styles, 50 progressions), exit 0; node scripts/validate-kb.mjs → ✓ KB valid — 10 style(s), 50 progressions, 100 plays (no KB change). Root-cause fix VERIFIED by running the real guideTones: hasSeventh now keys on the actual presence of interval 10 or 11 (ints.find(i=>i===10||i===11)), not length>=4. Independent truth table (root C): add9→{third:2,seventh:7,hasSeventh:false,anchor=5th G}; maj6→{4,7,false,5th}; min6→{3,7,false,5th}; dom7→{4,10,true,7=A♯}; maj7→{4,11,true,7=B}; min7→{3,10,true,7=A♯}; triads maj/min/sus4/sus2→false,anchor 5th(7); dim→anchor ♭5(6); aug→anchor #5(8); dim7→♭5(6); half_dim→true,10. Return shape {third, seventh, root, hasSeventh} unchanged (keys verified). Badge hardening (Fretboard) VERIFIED: focusSeventhLabel derives the label from the actual interval of the anchor pc above the chord root (10/11→"7", 9→"6", 8→"♭6", 7→"5", 6→"♭5"), so a wrong boolean can't mislabel — adversarial sweep of all 14 KB qualities × keys {3,7,11}: a "7" badge appears iff the interval is truly 10/11; NO MISLABEL. Unknown quality → maj fallback, no crash. Null-focus path byte-equivalent: jamFocusChord=null ⇒ hasFocus=false ⇒ tag always null ⇒ if(!color&&!tag) collapses to the original if(!color) return null; no halo/badge/legend; focusSeventhLabel is dead-but-harmless. No collateral: voiceLeadingPairs/soloScale signatures untouched (theory.js diff hits only guideTones body+jsdoc); ii–V–I rails still correct (Dm7→G7 C→B [0→11,−1]; G7→Cmaj7 F→E [5→4,−1]) and voiceLeadingPairs does NOT crash for the now-5th-anchored add9/maj6/min6 (Cadd9→G7, Cmaj6→F, Amin6→Dm7 all return smooth rails). match.js/RoadmapTrack/ChordDiagram/KB untouched (git diff --name-only = only the 4 declared D-03 files). 🚨 Audio contract INTACT: git diff -- src/App.jsx purely additive (one useState(jamFocusChord/null) outside the callback/ref block + an additive jamFocusChord= prop on <Fretboard> + onFocusChord=setJamFocusChord on <JamGuide>); grep of changed lines for handleNote|handleChroma|handleOnset|useCallback|AudioCapture|Ref|configRef|useEffect → NO MATCHES; the sole "−" line is the Fretboard mount being re-emitted with the added prop. Non-blocking observation (pre-existing, out of D-03 scope): guideTones uses ints[1] for the 3rd, so add9 [0,2,4,7] reports its 9th (pc 2) as third, not the major 3rd (pc 4) — true at L-01b time, unchanged by this fix, and D-03's bug was strictly the seventh/secondary anchor; worth a future tidy, not a return. GATE 2026-06-15 (Critic) · L-10 PASS — (re-gated cleanly after the prior dispatch died on an API error pre-verdict.) npm run build green (vite 7.3.1, 90 modules, built in 2.24s); node scripts/smoke.mjs → ✓ Smoke test passed — 71/71 checks green (10 styles, 50 progressions) exit 0; node scripts/validate-kb.mjs → ✓ KB valid — 10 style(s), 50 progressions, 100 plays. Purity confirmed by reading the full module: exports pianoVoicing({rootPc,quality},opts?)→{notes,pcs,bass,style,label} plus pianoVoicingChain, hasTrueSeventh, voicingToneSet (and re-exports guideTones); imports ONLY {CHORD_TYPES, guideTones} from ./theory; no Date/Math.random/module-level mutable state — determinism verified (every quality voiced twice → byte-identical). Music verified myself via a throwaway ESM script (deleted): swept all 14 CHORD_TYPES × 4 styles = 56 voicings at rootPc 0 — every pcs ⊆ voicingToneSet(...) (NO out-of-chord note), real 3rd present (sus→2/5), every TRUE 7th (interval 10/11: dom7/maj7/min7/half_dim) present in shell+rootless, all notes ∈ [0,36] (≤3 octaves), bass=min(notes). Spot-checks exact: Cmaj7 shell→{0,4,11} ✓, Dm7 rootlessA→{5,9,0,4}=F-A-C-E ✓, G7 shell→{7,11,5} ✓. Awkward qualities honest: half_dim shell→{0,3,10} (true ♭7 kept), rootlessA→{3,6,10,2} "3-5-7-9" ✓; dim7 correctly NOT a true-7th chord — its 7-slot is interval 9 (𝄫7 = enharmonic maj6, not 10/11), so hasTrueSeventh('dim7')=false, shells as R-3-5 {0,3,6}, no fabricated 7th; min6/maj6 (no true 7th) → root {0,3,7,9}/{0,4,7,9}, rootless labels honestly read "3-5-6-9" using the 6th as upper colour — no wrong note. Voice-leading confirmed: pianoVoicingChain([Dm7,G7,Cmaj7]) total semitone motion 16 vs 18 unthreaded (opts.prev slides whole shapes by octaves toward the previous voicing); pcs unchanged by threading (per-chord pc sets identical to unthreaded — re-registered only, never corrupted). Adversarial: bogus/empty/null chord → graceful maj fallback, no crash. One non-blocking nit (NOT a defect): forcing rootlessB (or rootlessA) explicitly onto a sus2 chord produces a cosmetic duplicate absolute note (notes=[26,26,31]) because the suspended-2nd "3rd-slot" tone (pc2) and the synthesized 9th (pc2) collide — still no wrong pc, in range, and honestly labeled "no 7th, 9-3-5 colour". It is unreachable on the shipping path: defaultStyle(sus2)='root' and L-11/pianoVoicingChain use defaults, so sus2 renders as clean root [0,2,7]; the dup only appears under an explicit forced-rootless override of a sus chord (documented graceful degradation). Default-style sweep of all 14 qualities confirmed zero duplicate notes. Recommend a future tidy (dedupe collided absolute notes in the rootless fallback) — not a return. src/lib/piano.js NOT edited; throwaway script removed. GATE 2026-06-15 (Critic) · D-02 PASS — the load-bearing integration is correct. Independent rotation check: canonicalPos = ((position − rotation) % n + n) % n translates a findLoopPosition index (which is into the detected loop) into the KB-canonical station RoadmapTrack/stationVoicings render. Worked a rotated [ii V I VI] of KB [I VI ii V] (rotation=2, n=4): playhead@detected-idx1(V)→canonical 3(V), @2(I)→0(I), @3(VI)→1(VI), @0(ii)→2(ii) — NOW lands on the chord actually playing. ✓ rootPc parity confirmed: thumbnail rootPc and RoadmapTrack station root are byte-identical (((keyRoot+deg)%12)+12)%12, and keyInfo.root (a note name, e.g. detectKey→"F#") is converted once via chordRootPC → pc, guarded >=0. stationVoicings chords[i] aligns 1:1 with degrees[i] (canonical). Auto-scroll is prop-driven off position (no rAF on the audio thread). Reflows (flex-wrap/sm:flex-nowrap), keyboard-reachable, AA contrast. NO_MATCH path → dashed fallback, never empty/crash. Non-blocking deferral: the DoD's "tap-station → fretboard guide tones" cross-link and tailwind.config.js edit were not delivered — the implementation cross-links via an inline enlarged ChordDiagram instead (flagged in-code as deferred). Panel is fully functional without it; recommend Maestro file the fretboard cross-link as a phase-2 follow-up.

Backlog (future sprints)

Jam Guide phase 2: MiniPiano.jsx + piano recipe resolver (unblocks piano packs); bass pattern renderer.
Content: piano packs (jazz → gospel → neo-soul first), then bass packs (blues → jazz → funk first) — see docs/kb-backlog.md.
guideTones third bug (L-12, Luthier — small): guideTones takes ints[1] as the "third", so add9 [0,2,4,7] reports its 9th (pc 2) as the 3rd instead of the major 3rd (pc 4) — wrong "3rd" lane/badge for add9 (live in gospel + pop-axis Cadd9). Pre-existing since L-01b; flagged by Critic during the D-03 re-gate. Fix: pick the actual 3rd/4th interval (3 or 4, or sus 2/5) rather than positional ints[1]. Smoke + a guideTones truth-table check.
Learning features (Professor + Luthier): drills tab seeded from docs/learn-curriculum.md; target-note highlighting; ear-training quiz on own chord history; pocket report from the onset pipeline.
Progression Builder (GOAL G3): key-relative palette, drag-reorder, Nashville-number toggle, voicing alternatives.
Platform (Herald): GitHub Pages docs site; "you're playing the Creep progression" engagement hook; contributor leaderboard for styles added.

Iteration log

(Maestro appends one line per completed iteration: <date> · <task ids done> · <next>.)

2026-06-14 · done: M-01 · in-review (awaiting user pick): D-00a/b/c viz concepts · next: D-SEL (user chooses) → then L-01/D-01/D-02 implement chosen concept
2026-06-15 · done: D-00a/b/c, D-SEL (Roadmap chosen), L-01 (match.js + banner refactor), L-01b (guideTones/voiceLeadingPairs/soloScale) — Critic PASS both · next: L-02 (JamGuide shell) → D-01 (RoadmapTrack) ‖ D-01b (ChordDiagram)
2026-06-15 · done: L-02 (JamGuide shell + App mount), D-01 (RoadmapTrack), D-01b (ChordDiagram), D-02 (assembly + playhead rotation + thumbnails) — Critic PASS all 4, audio contract intact (App.jsx +10/−0) · Roadmap Jam Guide MVP is live & builds green · next: D-03 (fretboard cross-link, backlog) ‖ P-01 (gospel content) ‖ H-01 (README reframe)
2026-06-15 · done: P-01 (gospel guitar pack — 5 progs × 2 plays, validator 9 styles/45/90), H-01 (README reframed as learning platform, stale frontend/ paths fixed) — Critic PASS both · next ready: P-02 (pop pack) ‖ H-02 (CONTRIBUTING) ‖ C-01 (smoke harness) ‖ D-03 (fretboard cross-link)
2026-06-15 · done: P-02 (pop guitar pack — KB now 10 styles/50/100), H-02 (CONTRIBUTING.md + issue templates), C-01 (scripts/smoke.mjs — 71/71, adversarially proven to catch a broken matcher) — Critic PASS all 3 · SPRINT sprint-jam-guide COMPLETE → opening PR to main · remaining (next sprint): D-03 fretboard cross-link, piano/bass packs, drills
2026-06-15 · done: D-03 (tap station → guide tones on the main Fretboard; root-cause fix to guideTones hasSeventh + badge hardening) — Critic returned once (add9/maj6/min6 mislabeled 5th/6th as "7"), fixed, PASS on re-gate · audio contract intact · folded into PR #2 (completes the flagship) · filed L-12 (guideTones third bug) to backlog · next: seed piano phase-2 sprint (resolver + MiniPiano + wire)
2026-06-15 · new sprint sprint-jamguide-piano cut off sprint-jam-guide (keeps PR #2 stable) · done: M-02 (seed), L-10 (src/lib/piano.js voicing resolver — shells/rootless A·B/root, voice-leading threading; Critic PASS, 56 voicings, 0 wrong notes) · next ready: D-10 (MiniPiano) ‖ C-10 (smoke piano) → then L-11 (wire piano tab) · L-10 chosen as a new unimported lib so the user's live frontend review stayed undisturbed

34 KiB Raw Blame History Unescape Escape