diff --git a/docs/plan.md b/docs/plan.md index 84475a9..a3c78b0 100644 --- a/docs/plan.md +++ b/docs/plan.md @@ -925,7 +925,7 @@ checkable change โ€” no redesigns.* quickstart, prerequisites (Ollama), where data lives, license note. Highest-ROI 20-minute task in the repo. - [x] **Scrub PII from `scripts/apple-signing.env.example`.** It contains a - real Apple ID email (`james.twose2711@gmail.com`) in a tracked file. + real Apple ID email in a tracked file. Replace with `you@example.com`. - [x] **Delete dead scaffold: `src/components/Greet.tsx` + the `greet` Tauri command in `src-tauri/src/lib.rs`.** Leftover from diff --git a/docs/repo-review.md b/docs/repo-review.md index 9cc65c2..38379dc 100644 --- a/docs/repo-review.md +++ b/docs/repo-review.md @@ -37,8 +37,9 @@ the README's data-locations table. ### P0-2. PII still in `scripts/apple-signing.env.example` `plan.md` ยง17.1 marks "Scrub PII" as done. It isn't: the file still contains -the real Apple ID (`james.twose2711@gmail.com`) and the real Team ID -(`4759TW4SDC`). 5-minute fix, do it before the next push. +the real Apple ID email and Team ID (and both docs quote them). 5-minute fix, +do it before the next push. Note: the values are already in git history from +earlier commits โ€” scrubbing stops future copies, not the past. ### P1-1. "Streaming" is a single fake token โ€” the biggest UX lever left diff --git a/scripts/apple-signing.env.example b/scripts/apple-signing.env.example index 77b9377..7ab435f 100644 --- a/scripts/apple-signing.env.example +++ b/scripts/apple-signing.env.example @@ -9,7 +9,7 @@ # 3. APPLE_PASSWORD: an app-specific password from https://account.apple.com # (Sign-In and Security -> App-Specific Passwords). NOT your normal password. # 4. APPLE_TEAM_ID: 10-char Team ID from https://developer.apple.com/account#MembershipDetailsCard -export APPLE_SIGNING_IDENTITY="Developer ID Application: Your Name (4759TW4SDC)" -export APPLE_ID="james.twose2711@gmail.com" +export APPLE_SIGNING_IDENTITY="Developer ID Application: Your Name (XXXXXXXXXX)" +export APPLE_ID="you@example.com" export APPLE_PASSWORD="xxxx-xxxx-xxxx-xxxx" -export APPLE_TEAM_ID="4759TW4SDC" \ No newline at end of file +export APPLE_TEAM_ID="XXXXXXXXXX" \ No newline at end of file